getJSDocReturnType gets return type from @type tags#25486
Merged
Conversation
Previously, getJSDocReturnType did not check the `@type` tag for a type node that has a return type. Now it does.
sandersn
commented
Jul 6, 2018
| return !!(node as HasType).type; | ||
| } | ||
|
|
||
| /* True if the node could have a type node a `.type` */ |
Member
Author
There was a problem hiding this comment.
I discovered this function was unused and deleted it along the way.
mhegazy
approved these changes
Jul 6, 2018
Contributor
|
@sandersn cool, I'm very happy it's useful for you! 😄 By the way, I will try to add typescript@next in the options soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, getJSDocReturnType did not check the
@typetag for a type node that has a return type. Now it does.Fixes #25424
This PR was aided by TypeScript AST Viewer. Thanks @dsherret for making it easy to write AST-wrangling code!